Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Relic Integration #17

Merged
merged 10 commits into from
Aug 27, 2024
Merged

New Relic Integration #17

merged 10 commits into from
Aug 27, 2024

Conversation

ispiroglu
Copy link
Contributor

@ispiroglu ispiroglu commented Aug 24, 2024 •
edited
Loading

WIP

Introduce a submodule concept.

Unlike otel and otelkafka modules, there are no 2 different modules for New Relic module.

The module accepts providers and the providers are in different packages to prevent unnecessary module imports.

otel example

app.Use(
  otel.Module(),
  otelserver.Module(),
  server.Module(),
)

new relic example

app.Use(
  newrelic.Module(
    nrserver.WithServer(),
    nrpsql.WithPostgesql(),
  ),
)

@ispiroglu ispiroglu linked an issue Aug 24, 2024 that may be closed by this pull request
new relic module #15
Closed
@ispiroglu
Copy link
Contributor Author

currently, module.provide(ctr ...any) accepts any, should we define a interface like

type Provider interface {
  Provide() any
}

or should we do define submodule interfaces in module itself and implement if in submodule packages?

@ahmetcanozcan ahmetcanozcan merged commit 3a7621e into main Aug 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new relic module
2 participants
@ispiroglu @ahmetcanozcan